[TMA] Update TMAStoreWaitOp to wait for the memory write to complete#10415
Merged
Conversation
Currently desc.store(...) does not guaruntee that that write is completed to global memory, so this makes message passing impossible. e.g. ``` desc.store(...) tl.atomic_xchg(flag, 1, sem="release") ``` does not release the store. To maintain perf in gluon, I also expose the read-only tma wait variant so users can explicitly opt-in to the behavior.
ThomasRaoux
reviewed
May 29, 2026
ThomasRaoux
left a comment
ThomasRaoux
left a comment
Collaborator
There was a problem hiding this comment.
actually thinking more about this if it is true it means something is broken in the acquire/release semantic of ptx ops. Are you sure the example you have doesn't work?
Contributor
Author
Collaborator
sad, anyway makes sense, hopefully it doesn't affect perf significantly |
ThomasRaoux
added a commit
that referenced
this pull request
Jun 2, 2026
Use read-only waits for pipelined TMA stores so the in-loop wait only protects shared-memory staging buffer reuse. Skip TMA store pipelining when the loop contains acquire or release atomics so those memory-ordering cases keep the non-pipelined descriptor store lowering. This recovers some performance regression caused by [#10415](#10415)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently desc.store(...) does not guaruntee that that write is completed to global memory, so this makes message passing impossible.
e.g.
does not release the store.
To maintain perf in gluon, I also expose the read-only tma wait variant so users can explicitly opt-in to the behavior.